Skip to content

Set mountPropagation: HostToContainer on the runtime socket volume - #3153

Open
akhil9tiet wants to merge 4 commits into
NVIDIA:mainfrom
akhil9tiet:fix/3083-socket-mount-propagation
Open

akhil9tiet wants to merge 4 commits into
NVIDIA:mainfrom
akhil9tiet:fix/3083-socket-mount-propagation

Conversation

@akhil9tiet

@akhil9tiet akhil9tiet commented Oct 30, 2026 •

Copy link
Copy Markdown

Fixes #3083.

Description

The container-toolkit DaemonSet mounts the runtime socket directory (e.g. /run/containerd -> /runtime/sock-dir/) as a private bind. Because the toolkit container's own rootfs lives under that directory and the copy never receives host unmount events, any host mount present at container start (including ZFS datasets, via the /host sub-mount) stays pinned in the container's mount namespace - zfs destroy then fails with "dataset is busy" until the toolkit container restarts. transformRuntimeConfigAndSocketMounts in controllers/object_controls.go is the only place that creates this socket VolumeMount, so the fix sets mountPropagation: HostToContainer there, matching the existing host-root and driver-install-dir mounts.

Checklist

  • No secrets, sensitive information, or unrelated changes
  • Lint checks passing (make lint) - ran go vet (clean); golangci-lint was not available in this environment
  • Generated assets in-sync (no API/chart changes)
  • Go mod artifacts in-sync (no dependency changes)
  • Test cases are added for new code paths (expected VolumeMounts in TestTransformForRuntime/TestTransformToolkit now assert HostToContainer on the socket mount; verified the tests fail without the fix)

Testing

  • go vet ./controllers/ clean; gofmt clean.
  • go test ./controllers/ -run 'TestTransformForRuntime|TestTransformToolkit' passes; full go test ./controllers/ package passes.
  • Regression check: with the fix reverted, the tests fail (MountPropagation: HostToContainer expected vs nil actual); with the fix, they pass.
  • NOTE: I could not verify on an affected setup (no GPU node / ZFS hardware available) - runtime before/after evidence (host unmounts propagating, zfs destroy succeeding) still needs a maintainer or CI run to confirm.

Devin Review

The toolkit container's runtime socket bind (e.g. /run/containerd) is a private recursive bind, so the host mount tree is copied into the container's mount namespace at start and never receives host unmount events, pinning host mounts (e.g. ZFS datasets) and blocking zfs destroy with "dataset is busy". Set HostToContainer propagation on the socket VolumeMount, matching host-root and driver-install-dir.

Fixes NVIDIA#3083.

Signed-off-by: Akhil Gupta <akhil9tiet@users.noreply.github.com>
The toolkit container's runtime socket bind (e.g. /run/containerd) is a private recursive bind, so the host mount tree is copied into the container's mount namespace at start and never receives host unmount events, pinning host mounts (e.g. ZFS datasets) and blocking zfs destroy with "dataset is busy". Set HostToContainer propagation on the socket VolumeMount, matching host-root and driver-install-dir.

Fixes NVIDIA#3083.

Signed-off-by: Akhil Gupta <akhil9tiet@users.noreply.github.com>
@akhil9tiet
akhil9tiet requested a review from a team as a code owner October 30, 2026 05:39
@copy-pr-bot

copy-pr-bot Bot commented Oct 30, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@coderabbitai

coderabbitai Bot commented Oct 30, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between f925d27 and 9d16fc9.

Files selected for processing: 2
  • controllers/object_controls.go
  • controllers/transforms_test.go

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

Walkthrough

The runtime socket volume mount now uses HostToContainer propagation. Transformation test expectations cover containerd and Docker runtime mounts, plus toolkit transformations with default and custom containerd sockets.

Priority: Normal

Severity of issue fixed: Medium

Merge Risk: Minimal · up to 9d16f

No actionable merge-blocking risk is established; the requested socket propagation configuration is implemented and covered by tests.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@kvalliyurnatt

Copy link
Copy Markdown
Contributor

@akhil9tiet can you squash the commits into one and rebase as well.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants