Repository navigation
Set mountPropagation: HostToContainer on the runtime socket volume - #3153
Open
akhil9tiet wants to merge 4 commits into
Open
akhil9tiet wants to merge 4 commits into
akhil9tiet wants to merge 4 commits into
Conversation
The toolkit container's runtime socket bind (e.g. /run/containerd) is a private recursive bind, so the host mount tree is copied into the container's mount namespace at start and never receives host unmount events, pinning host mounts (e.g. ZFS datasets) and blocking zfs destroy with "dataset is busy". Set HostToContainer propagation on the socket VolumeMount, matching host-root and driver-install-dir. Fixes NVIDIA#3083. Signed-off-by: Akhil Gupta <akhil9tiet@users.noreply.github.com>
The toolkit container's runtime socket bind (e.g. /run/containerd) is a private recursive bind, so the host mount tree is copied into the container's mount namespace at start and never receives host unmount events, pinning host mounts (e.g. ZFS datasets) and blocking zfs destroy with "dataset is busy". Set HostToContainer propagation on the socket VolumeMount, matching host-root and driver-install-dir. Fixes NVIDIA#3083. Signed-off-by: Akhil Gupta <akhil9tiet@users.noreply.github.com>
|
No actionable comments were generated in the recent review.
|
Contributor
|
@akhil9tiet can you squash the commits into one and rebase as well. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3083.
Description
The container-toolkit DaemonSet mounts the runtime socket directory (e.g. /run/containerd -> /runtime/sock-dir/) as a private bind. Because the toolkit container's own rootfs lives under that directory and the copy never receives host unmount events, any host mount present at container start (including ZFS datasets, via the /host sub-mount) stays pinned in the container's mount namespace -
zfs destroythen fails with "dataset is busy" until the toolkit container restarts.transformRuntimeConfigAndSocketMountsincontrollers/object_controls.gois the only place that creates this socket VolumeMount, so the fix setsmountPropagation: HostToContainerthere, matching the existinghost-rootanddriver-install-dirmounts.Checklist
make lint) - rango vet(clean); golangci-lint was not available in this environmentTesting
go vet ./controllers/clean;gofmtclean.go test ./controllers/ -run 'TestTransformForRuntime|TestTransformToolkit'passes; fullgo test ./controllers/package passes.zfs destroysucceeding) still needs a maintainer or CI run to confirm.